Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
github-actions
bot
added
help-wanted
Summary of ChangesHello @swissspidy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the project's static analysis capabilities by updating a core dependency and refining the PHPStan configuration. It introduces more explicit PHPDoc type hints across various command classes, which helps in catching potential type-related issues earlier and enhances code maintainability. Additionally, it adjusts code quality checks to better accommodate testing utilities. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This PR tightens PHPStan type-safety across the language command package by replacing broad PHPStan ignore rules with more precise PHPDoc types and a small PHPStan scan bootstrap, aiming to surface real type issues instead of suppressing them globally.
Changes:
- Adds a PHPStan scan file and wires it into
phpstan.neon.dist. - Improves PHPDoc typing for command properties/parameters and various translation-related data structures.
- Replaces global PHPStan ignores with more localized suppressions and bumps the
wp-cli/wp-clidependency constraint.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/phpstan/scan-files.php | Adds a PHPStan-scanned file to define WordPress constants for analysis. |
| src/WP_CLI/LanguagePackUpgrader.php | Adds a local PHPStan suppression for an untyped iterable parameter. |
| src/WP_CLI/CommandWithTranslation.php | Adds property/parameter typing and refines translation update typing; introduces localized PHPStan suppressions. |
| src/Theme_Language_Command.php | Adds more specific PHPDoc types for install subcommand args. |
| src/Plugin_Language_Command.php | Adds more specific PHPDoc types for install args and plugin list return type. |
| src/Site_Switch_Language_Command.php | Adds PHPDoc param typing for the invokable command handler. |
| src/Core_Language_Command.php | Adds a parameter PHPDoc type for a private helper. |
| phpstan.neon.dist | Adds scan file and removes several global ignore rules. |
| phpcs.xml.dist | Excludes the new phpstan test directory from the PrefixAllGlobals sniff. |
| composer.json | Updates wp-cli/wp-cli requirement from ^2.12 to ^2.13. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.